refactor: Use render_globe_dropdown for phone and desktop layouts 🗺️#667
Open
darcywong00 wants to merge 4 commits intomasterfrom
Open
refactor: Use render_globe_dropdown for phone and desktop layouts 🗺️#667darcywong00 wants to merge 4 commits intomasterfrom
render_globe_dropdown for phone and desktop layouts 🗺️#667darcywong00 wants to merge 4 commits intomasterfrom
Conversation
User Test ResultsTest specification and instructions User tests are not required |
ermshiperete
approved these changes
Feb 24, 2026
| echo <<<END | ||
| <li><a href="{$id[0]}">{$id[1]}</a></li> | ||
| END; | ||
| } |
Contributor
There was a problem hiding this comment.
Are we missing </ul> ?
_includes/2020/templates/Menu.php
Outdated
| * Render the globe dropdown for changing the UI language | ||
| * Limitation: Currently only visible on pages that use localized strings | ||
| * @param number - Div number, default 0. | ||
| * @param divClass - Div class, default 0, or 1 (for desktop); or "phone". |
Contributor
There was a problem hiding this comment.
I wonder if we should use "desktop" instead of 1 and "default" instead of 0. That would make it consistent and IMO easier to read.
Contributor
Author
There was a problem hiding this comment.
The parameter was originally for keeping unique <div> id's on the page for the UI list to hover on the globe.
Desktop layout used ui-language and ui-language1
Not applicable for phone layout. I'll just rename the parameter to divID.
darcywong00
force-pushed
the
fix/globe-phone
branch
from
b8a2c82 to
ba7318f
Compare
ermshiperete
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #384
This refactors the globe key (keyboard search UI) so it's also available on the phone layout menu.
Screenshot of phone menu
Test-bot: skip